remove the backup prompt

certbot/account.py

@@ -82,22 +82,6 @@ class Account(object):  # pylint: disable=too-few-public-methods
                 self.key == other.key and self.regr == other.regr and
                 self.meta == other.meta)
 
-
-def report_new_account(config):
-    """Informs the user about their new ACME account."""
-    reporter = zope.component.queryUtility(interfaces.IReporter)
-    if reporter is None:
-        return
-    reporter.add_message(
-        "Your account credentials have been saved in your Certbot "
-        "configuration directory at {0}. You should make a secure backup "
-        "of this folder now. This configuration directory will also "
-        "contain certificates and private keys obtained by Certbot "
-        "so making regular backups of this folder is ideal.".format(
-            config.config_dir),
-        reporter.MEDIUM_PRIORITY)
-
-
 class AccountMemoryStorage(interfaces.AccountStorage):
     """In-memory account storage."""
 

certbot/client.py

@@ -170,7 +170,6 @@ def register(config, account_storage, tos_cb=None):
         regr = acme.agree_to_tos(regr)
 
     acc = account.Account(regr, key)
-    account.report_new_account(config)
     account_storage.save(acc, acme)
 
     eff.handle_subscription(config)

certbot/tests/account_test.py

@@ -58,28 +58,6 @@ class AccountTest(unittest.TestCase):
         self.assertTrue(repr(self.acc).startswith(
           "<Account(i_am_a_regr, bca5889f66457d5b62fbba7b25f9ab6f, Meta("))
 
-class ReportNewAccountTest(unittest.TestCase):
-    """Tests for certbot.account.report_new_account."""
-
-    def setUp(self):
-        self.config = mock.MagicMock(config_dir="/etc/letsencrypt")
-
-    def _call(self):
-        from certbot.account import report_new_account
-        report_new_account(self.config)
-
-    @mock.patch("certbot.account.zope.component.queryUtility")
-    def test_no_reporter(self, mock_zope):
-        mock_zope.return_value = None
-        self._call()
-
-    @mock.patch("certbot.account.zope.component.queryUtility")
-    def test_it(self, mock_zope):
-        self._call()
-        call_list = mock_zope().add_message.call_args_list
-        self.assertTrue(self.config.config_dir in call_list[0][0][0])
-
-
 class AccountMemoryStorageTest(unittest.TestCase):
     """Tests for certbot.account.AccountMemoryStorage."""
 

certbot/tests/client_test.py

@@ -46,26 +46,23 @@ class RegisterTest(unittest.TestCase):
         with mock.patch("certbot.client.acme_client.Client") as mock_client:
             mock_client.register().terms_of_service = "http://tos"
             with mock.patch("certbot.eff.handle_subscription") as mock_handle:
-                with mock.patch("certbot.account.report_new_account"):
-                    self.tos_cb.return_value = False
-                    self.assertRaises(errors.Error, self._call)
-                    self.assertFalse(mock_handle.called)
+                self.tos_cb.return_value = False
+                self.assertRaises(errors.Error, self._call)
+                self.assertFalse(mock_handle.called)
 
-                    self.tos_cb.return_value = True
-                    self._call()
-                    self.assertTrue(mock_handle.called)
+                self.tos_cb.return_value = True
+                self._call()
+                self.assertTrue(mock_handle.called)
 
-                    self.tos_cb = None
-                    self._call()
-                    self.assertEqual(mock_handle.call_count, 2)
+                self.tos_cb = None
+                self._call()
+                self.assertEqual(mock_handle.call_count, 2)
 
     def test_it(self):
         with mock.patch("certbot.client.acme_client.Client"):
-            with mock.patch("certbot.account.report_new_account"):
-                with mock.patch("certbot.eff.handle_subscription"):
-                    self._call()
+            with mock.patch("certbot.eff.handle_subscription"):
+                self._call()
 
-    @mock.patch("certbot.account.report_new_account")
     @mock.patch("certbot.client.display_ops.get_email")
     def test_email_retry(self, _rep, mock_get_email):
         from acme import messages
@@ -79,7 +76,6 @@ class RegisterTest(unittest.TestCase):
                 self.assertEqual(mock_get_email.call_count, 1)
                 self.assertTrue(mock_handle.called)
 
-    @mock.patch("certbot.account.report_new_account")
     def test_email_invalid_noninteractive(self, _rep):
         from acme import messages
         msg = "DNS problem: NXDOMAIN looking up MX for example.com"
@@ -97,13 +93,12 @@ class RegisterTest(unittest.TestCase):
     def test_without_email(self, mock_logger):
         with mock.patch("certbot.eff.handle_subscription") as mock_handle:
             with mock.patch("certbot.client.acme_client.Client"):
-                with mock.patch("certbot.account.report_new_account"):
-                    self.config.email = None
-                    self.config.register_unsafely_without_email = True
-                    self.config.dry_run = False
-                    self._call()
-                    mock_logger.info.assert_called_once_with(mock.ANY)
-                    self.assertTrue(mock_handle.called)
+                self.config.email = None
+                self.config.register_unsafely_without_email = True
+                self.config.dry_run = False
+                self._call()
+                mock_logger.info.assert_called_once_with(mock.ANY)
+                self.assertTrue(mock_handle.called)
 
     def test_unsupported_error(self):
         from acme import messages