Compare commits

...

1 Commits

Author SHA1 Message Date
Joona Hoikkala
50cb6975bc Properly handle None value for installer in updater 2018-07-10 10:43:25 +03:00
2 changed files with 12 additions and 0 deletions

View File

@@ -263,6 +263,10 @@ def cli_plugin_requests(config): # pylint: disable=too-many-branches
:rtype: tuple
"""
req_inst = req_auth = config.configurator
if config.installer == 'None':
config.installer = None
if config.authenticator == 'None':
config.authenticator = None
req_inst = set_configurator(req_inst, config.installer)
req_auth = set_configurator(req_auth, config.authenticator)

View File

@@ -215,6 +215,14 @@ class GetUnpreparedInstallerTest(test_util.ConfigTestCase):
self.mock_apache_fail_ep.name = "apache"
self.assertRaises(errors.PluginSelectionError, self._call)
def test_return_early_if_none(self):
self.config.installer = 'None'
# Make sure that the function returns early. PluginsRegistry.filter is
# called right after we should return.
with mock.patch('certbot.plugins.disco.PluginsRegistry.filter') as mock_f:
self._call()
self.assertFalse(mock_f.called)
if __name__ == "__main__":
unittest.main() # pragma: no cover